Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the Dictionary with HashSet in AppDomainShutdownMonitor #3932

Merged

Conversation

lindexi
Copy link
Member

@lindexi lindexi commented Dec 27, 2020

Benchmark:

Method argList Mean Error StdDev Ratio RatioSD
'AddAndRemove Old' Syste(...)ence] [55] 679.7 us 10.42 us 8.70 us 1.00 0.00
'AddAndRemove New' Syst(...)er]] [113] 667.7 us 11.07 us 10.35 us ? ?
Method argList Mean Error StdDev Ratio RatioSD
'AddBeforeRemove Old' Syste(...)ence] [55] 1.414 ms 0.0174 ms 0.0154 ms 1.00 0.00
'AddBeforeRemove New' Syst(...)er]] [113] 1.197 ms 0.0097 ms 0.0081 ms ? ?
Method Mean Error StdDev Median Ratio RatioSD
'AddOnly Old' 2.886 ms 0.0574 ms 0.1160 ms 2.821 ms 1.00 0.00
'AddOnly New' 2.880 ms 0.0639 ms 0.1865 ms 2.827 ms 1.00 0.09

Benchmark Code: https://github.com/lindexi/lindexi_gd/tree/b63ba44c2077bcc4136455f16b309fe74a288dcc/AppDomainShutdownMonitor

@lindexi lindexi requested a review from a team as a code owner December 27, 2020 02:56
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Dec 27, 2020
@ghost ghost requested review from fabiant3, ryalanms and SamBent December 27, 2020 02:56
@ryalanms
Copy link
Member

Thanks again, @lindexi.

@ryalanms ryalanms merged commit d9171ca into dotnet:master Jan 12, 2021
@lindexi lindexi deleted the t/lindexi/AppDomainShutdownMonitorHashSet branch January 13, 2021 00:30
@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2022
@ghost ghost assigned lindexi May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants