Call SHA1.HashData static helper instead of instantiating SHA1CSP #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
|
This code is actually copied from C#/WinRT. Once the support for WinRT interop flows into the SDK in a way that WPF can consume, this file is supposed to be removed. You may want to submit this fix to the C#/WinRT repo instead. |
ryalanms
approved these changes
Jan 7, 2021
|
Thanks, @GrabYourPitchforks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're trying to minimize usage of the
*CryptoServiceProviderand*Managedtypes through our code bases so that we can eventually write analyzers to recommend moving off of them. See dotnet/runtime#40169 for some related discussion w.r.t.RNGCryptoServiceProvider.This PR changes the call site to use the static one-shot helper method so that you don't need to instantiate a hasher object. The
HashDatastatic method uses the best available implementation for the current OS.