msbuild patch to remove BuildXL feed #44199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ViktorHofer
reviewed
Oct 15, 2024
| Date: Tue, 15 Oct 2024 14:24:55 -0500 | ||
| Subject: [PATCH] Remove BuildXL feed | ||
|
|
||
| Backport: https://github.com/dotnet/msbuild/pull/10765 |
There was a problem hiding this comment.
This links to the main PR. I see that the line still exists in vs17.12: https://github.com/dotnet/msbuild/blob/0258a80c00f599c2b0564d0429cd52f4d815e83c/NuGet.config#L21
There was a problem hiding this comment.
Yes, I've already responded at dotnet/msbuild#10765 (comment) that this needs to be backported.
There was a problem hiding this comment.
Do we source build only 1xx versions? Is 8.0.1xx enough (so backporting to 17.8 https://learn.microsoft.com/en-us/dotnet/core/porting/versioning-sdk-msbuild-vs#versioning)? Or do we need it in all 8.0 versions?
There was a problem hiding this comment.
Just the 1xx versions should be sufficient.
ellahathaway
approved these changes
Oct 15, 2024
3 tasks
marcpopMSFT
added a commit
that referenced
this pull request
Oct 18, 2024
This reverts commit 75d8977.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #44194