Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test targets need to be part of main SDK #546

Closed
clairernovotny opened this issue Dec 22, 2016 · 6 comments
Closed

Test targets need to be part of main SDK #546

clairernovotny opened this issue Dec 22, 2016 · 6 comments
Milestone

Comments

@clairernovotny
Copy link

Right now, it seems the only way to invoke unit test projects via the test platform is to use dotnet test on the project file. The problem is that forces the CoreCLR version of the Build tasks and not all tasks work on CoreCLR.

For example:
https://github.com/Reactive-Extensions/Rx.NET/blob/f339ba7c0821d00f9c0cb29186c97713765a6d03/Rx.NET/Source/Tests.System.Reactive/Tests.System.Reactive.csproj

I cannot simply run dotnet test on that because the GitVersionTask is .NET Desktop only. That's fine for building, but I then need a way to invoke the test platform once per target framework with the right parameters.

It should do whatever dotnet test is...I think it's going to vstest.console /Framework: ... with the supported frameworks.

It seems that Microsoft.TestPlatform.targets is in the CLI build but not in the main SDK. It should be in the main SDK for use with msbuild.

@jaredpar
Copy link
Member

Related issue dotnet/msbuild#1499

@srivatsn
Copy link
Contributor

@dotnet/vstest This is a request for running tests using the desktop msbuild - a msbuild /t:Test.

@pvlakshm
Copy link

pvlakshm commented Jan 9, 2017

We've added this ask to backlog. However we will likely get to it post RTM.

@clairernovotny
Copy link
Author

This really needs to be in 1.0...otherwise, given that these targets are distributed with VS 2017 and not via NuGet, it'll need to wait for Update 1, wont' it?. We need a coherent unit test strategy out-of-the-box.

@codito
Copy link
Contributor

codito commented Jan 11, 2017

We're considering the option to pull the target/task into a nuget package or use the existing Microsoft.NET.Test.Sdk.

@srivatsn
Copy link
Contributor

This issue was moved to microsoft/vstest#387

mmitche pushed a commit to mmitche/sdk that referenced this issue Jun 5, 2020
GangWang01 pushed a commit to GangWang01/sdk that referenced this issue Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants