Convert dotnet/runtime to use the new Arcade tooling for RPMs #109526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… linux non-musl, including in the VMR. Fixes dotnet/source-build#4138
…or producing them in separate steps in special containers and remove our references to those containers
am11
reviewed
Nov 4, 2024
|
|
||
| <PropertyGroup> | ||
| <BuildDebPackage Condition="'$(TargetsLinuxGlibc)' == 'true'">true</BuildDebPackage> | ||
| <BuildRpmPackage Condition="'$(TargetsLinuxGlibc)' == 'true'">true</BuildRpmPackage> |
There was a problem hiding this comment.
These are set in .proj files, do we also need them in .props file?
There was a problem hiding this comment.
Yes. This provides the defaults for the installers, but the runtime-deps installers only build some of the flavors (deb or rpm, not both).
|
Looks like cpio isn't available in the Azl3 docker images we use... I might have to update the image to install it. |
|
Apparently Docker image updates in dotnet/dotnet-buildtools-prereqs-docker#1247 |
This was referenced Nov 7, 2024
Open
ViktorHofer
approved these changes
Nov 8, 2024
|
/ba-g unrelated work item crash |
This was referenced Nov 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109518
Fixes dotnet/source-build#4138
Contributes to dotnet/source-build#3986
Depends on dotnet/arcade#15217