Fix PowerShell Script Issues #76219
Merged
Fix PowerShell Script Issues #76219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran into issues running PowerShell script issues tonight looking at determinism. After digging down discovered that our scripts didn't run correctly when launching the .cmd files from a pwsh shell. Changed our cmd to avoid this problem. PowerShell/PowerShell#24630
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
3 tasks
|
@dotnet/roslyn-infrastructure PTAL |
333fred
approved these changes
Dec 2, 2024
RikkiGibson
approved these changes
Dec 2, 2024
| @@ -286,8 +287,8 @@ try { | |||
|
|
|||
| if ($bootstrapDir -eq "") { | |||
| Write-Host "Building bootstrap compiler" | |||
| $bootstrapDir = Join-Path $ArtifactsDir "bootstrap" "determinism" | |||
| & eng/make-bootstrap.ps1 -output $bootstrapDir -ci:$ci | |||
| $bootstrapDir = Join-Path $ArtifactsDir (Join-Path "bootstrap" "determinism") | |||
There was a problem hiding this comment.
What's the motivation/impact of splitting this into multiple calls here?
There was a problem hiding this comment.
The Join-Path in powershell does not accept arbitrary numbers of arguments, only two. In pwsh it accepts arbitrary.
This went overlooked because this code path doesn't execute in CI as we manually build a bootstrap compiler. It only comes into play when working locally.
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into issues running PowerShell script issues tonight looking at determinism. After digging down discovered that our scripts didn't run correctly when launching the .cmd files from a pwsh shell. Changed our cmd to avoid this problem.
PowerShell/PowerShell#24630