Ix optimizations #237
Merged
Ix optimizations #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairernovotny
force-pushed
the
ix-optimizations
branch
from
dbeb991 to
e42909b
Compare
clairernovotny
force-pushed
the
ix-optimizations
branch
3 times, most recently
from
ec44685 to
dc71ce7
Compare
| { | ||
| var result = await ToArrayWithLength(source, cancellationToken) | ||
| .ConfigureAwait(false); | ||
| Array.Resize(ref result.array, result.length); |
There was a problem hiding this comment.
Nit: can move this to a ToArray method onArrayWithLength<T>.
clairernovotny
force-pushed
the
ix-optimizations
branch
from
97ff53e to
59da899
Compare
clairernovotny
force-pushed
the
ix-optimizations
branch
from
0b039e1 to
3ece9f4
Compare
|
/cc @aelij for any code review feedback |
|
|
||
| public Task<int> GetCountAsync(bool onlyIfCheap, CancellationToken cancellationToken) | ||
| { | ||
| return Task.FromResult(source.Count()); |
There was a problem hiding this comment.
Use Count instead of Count() since source is an IList.
…eateEnumerator/CreateEnumerable to document requirements
…d diagnostic ability
clairernovotny
force-pushed
the
ix-optimizations
branch
from
f9ae103 to
ea63796
Compare
This was referenced Sep 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to optimize Ix Async by incorporating the patterns used in https://github.com/dotnet/corefx/tree/master/src/System.Linq/src/System/Linq, taking advantage of the thought leadership and performance reviews of that codebase.