Don't throw on lazy item updating unexpanded globs #9409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KirillOsenkov
approved these changes
Nov 8, 2023
AR-May
approved these changes
Nov 10, 2023
An Item `Update` operation may apply to items that are defined via wildcard. In normal operation, the wildcard will have been expanded by the time Update applies, and it's fine for Update to assume that everything is a valid file path. But in `MSBuildSkipEagerWildCardEvaluationRegexes` mode, wildcards may not be expanded. Fixes dotnet#9405 by using a more appropriate method to normalize probably-but-not-necessarily paths for comparisons.
rainersigwald
force-pushed
the
glob-disable-updates-crash
branch
from
1eff9c2 to
98818e6
Compare
YuliiaKovalova
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Item
Updateoperation may apply to items that are defined viawildcard. In normal operation, the wildcard will have been expanded by
the time Update applies, and it's fine for Update to assume that
everything is a valid file path. But in
MSBuildSkipEagerWildCardEvaluationRegexesmode, wildcards may not beexpanded.
Fixes #9405 by using a more appropriate method to normalize
probably-but-not-necessarily paths for comparisons.