Make the cancelation can be executed before the task is done #11225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fore the task is done
GangWang01
force-pushed
the
downloadfile-flaky-test
branch
from
a83e0d4 to
bdd4baa
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JanKrivanek
reviewed
Jan 7, 2025
SimaTian
reviewed
Jan 14, 2025
…f milliseconds without high memory cost instead
SimaTian
previously approved these changes
Jan 20, 2025
SimaTian
reviewed
Jan 20, 2025
GangWang01
changed the title
SimaTian
approved these changes
Jan 21, 2025
JanKrivanek
approved these changes
Jan 21, 2025
maridematte
approved these changes
Jan 22, 2025
…gic and add a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11018
Context
Test result
Shouldly.ShouldAssertException : task.Result\r\n should be\r\nFalse\r\n but was\r\nTrueindicates that the task is done quickly before the cancelation is executed, though the test cancels it right after it is started.Changes Made
Make a fake stream that provides a single character A~Z per a couple of milliseconds infinitely without high memory cost as the content of http response message and increase the task timeout a little so that the cancellation can be executed.
Testing
N/A
Notes