Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to avoid "fixing" \ in new TaskItem() #11120

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Conversation

maridematte
Copy link
Contributor

Fixes #11083

Context

Sometimes TaskItems are not file paths, and we currently treat all of them as file paths and try to fix backslashes into slashes.

Changes Made

Added an option where TaskItems can be created without a reference to a path, and it will not try to fix it.

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Let's get rid of default param

@maridematte maridematte requested a review from jeffkl December 13, 2024 14:11
@maridematte maridematte enabled auto-merge (squash) December 13, 2024 15:51
@maridematte maridematte merged commit 8c0edd2 into dotnet:main Dec 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to avoid "fixing" \ in new TaskItem()
4 participants