Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert backport pr 10942 to vs17.12 #11088

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Revert backport pr 10942 to vs17.12 #11088

merged 5 commits into from
Dec 5, 2024

Conversation

SimaTian
Copy link
Member

@SimaTian SimaTian commented Dec 5, 2024

Due to breaking more stuff than intended, I'm reverting this PR to be in sync with main.

@SimaTian SimaTian requested a review from a team as a code owner December 5, 2024 10:51
JanKrivanek
JanKrivanek reviewed Dec 5, 2024
View reviewed changes
JanKrivanek
JanKrivanek approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

Please make sure the version is increased

YuliiaKovalova
YuliiaKovalova approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@YuliiaKovalova YuliiaKovalova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve issue with the version and it's ready to go.

@SimaTian SimaTian merged commit bc692d0 into vs17.12 Dec 5, 2024
10 checks passed
@SimaTian SimaTian deleted the revert-backport-pr-10942-to-vs17.12 branch December 5, 2024 12:49
@JanKrivanek JanKrivanek mentioned this pull request Dec 5, 2024
Merged
SimaTian added a commit that referenced this pull request Dec 6, 2024
@SimaTian
Revert "Revert backport pr 10942 to vs17.12 (#11088)"
d8ab229 
This reverts commit bc692d0.
@SimaTian SimaTian mentioned this pull request Dec 6, 2024
Merged
SimaTian added a commit that referenced this pull request Dec 6, 2024
@SimaTian
Revert "Revert backport pr 10942 to vs17.12" (#11096)
762f59c 
* Revert "Revert backport pr 10942 to vs17.12 (#11088)"

This reverts commit bc692d0.

* Update Versions.props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanKrivanek JanKrivanek JanKrivanek approved these changes

@YuliiaKovalova YuliiaKovalova YuliiaKovalova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimaTian @JanKrivanek @YuliiaKovalova