Add IntelliSense for testing properties #11029
Conversation
There was a problem hiding this comment.
Global comments:
Some details like nuget packages, extensions included in profiles... are probably better not explained here but instead linked into doc so we could better handle changes and more complex details in the future.
You are sometimes wrapping values in single quotes sometimes not. It's probably better to always do it for property name, values and package names.
Co-authored-by: Amaury Levé <[email protected]>
|
Is it needed for VS functionality only? |
@YuliiaKovalova Ideally, we want the completion to work fine everywhere. VS, VSCode, Rider. I have no idea if the XSD is respect only in VS or is respected everywhere. And if not respected everywhere, is there even a way to get it to work everywhere? |
Co-authored-by: Amaury Levé <[email protected]>
Today this only works in VS. Getting it to work everywhere is tracked by #1774. |
|
@rainersigwald This is green now. Is it good to merge please? |
There was a problem hiding this comment.
@JanKrivanek I can't think of a reason not to take this to 17.13--is that still ok timeline-wise?
|
@rainersigwald @YuliiaKovalova @JanKrivanek Is this good to merge? |
|
It's good to go! @Youssef1313 - did you have in mind any timeline of shipping this? Is early Feb with 17.14 Preview 1 fine? |
|
I haven't planned a timeline with @Evangelink on this. I think it should be fine early Feb, but will double check. |
|
Sure, the earlier the better but this is absent for some time so it's not blocking anything. Thanks. |
Fixes microsoft/testfx#4118
@Evangelink @nohwnd for review.