Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/vs17.8] Onboard 1es templates #10062

Closed
wants to merge 1 commit into from

Conversation

surayya-MS
Copy link
Member

Copy link
Contributor

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

@surayya-MS surayya-MS marked this pull request as ready for review April 23, 2024 16:18
@YuliiaKovalova
Copy link
Member

@rainersigwald , do we want to backport?
#10042

@rainersigwald
Copy link
Member

I would expect a 17.7->17.8 merge to be the way to do this. Is that not a good option?

@surayya-MS
Copy link
Member Author

I would expect a 17.7->17.8 merge to be the way to do this. Is that not a good option?

There were changes from #10042 that we don't want in 17.8 I believe. @JanKrivanek correct me please

@JanKrivanek
Copy link
Member

It seems that 17.7 -> 17.8 codeflow was not accepted/merged for couple changes in a row: https://github.com/dotnet/msbuild/pulls?q=is%3Apr+%27vs17.7%27+%3D%3E+%27vs17.8+is%3Aclosed, so I suggested not to use the flow (as it had huge amount of untrelated changes) and do that manually.

Though - we still should backport #10024 manually

@surayya-MS
Copy link
Member Author

Thanks @JanKrivanek! I'll do #10042 backport to vs17.8 manually then

@surayya-MS
Copy link
Member Author

closing this PR in favor of #10056

@surayya-MS surayya-MS closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants