Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pack project or script for the Analyzers authoring template #9915

Closed
JanKrivanek opened this issue Mar 25, 2024 · 0 comments · Fixed by #10155
Closed

Add pack project or script for the Analyzers authoring template #9915

JanKrivanek opened this issue Mar 25, 2024 · 0 comments · Fixed by #10155
Assignees
@JaynieBai
Labels
Area: BuildCheck

Comments

@JanKrivanek
Copy link
Member

Context

#9789 added a template for custom analyzer.
In order for that to be usable by our customers - we need to be publishing this to nuget feed along with our other binaries. So we should have the package produced from our repo - ideally as part of our build script

Goal

  • The template is packed into versioned nuget package during the run of build.cmd
@JanKrivanek JanKrivanek mentioned this issue Mar 25, 2024
Merged
@GangWang01 GangWang01 mentioned this issue Mar 26, 2024
Closed
@GangWang01 GangWang01 self-assigned this Mar 26, 2024
@JaynieBai JaynieBai assigned JaynieBai and unassigned GangWang01 Apr 2, 2024
@JaynieBai JaynieBai mentioned this issue May 20, 2024
Merged
JaynieBai added a commit that referenced this issue May 27, 2024
@JaynieBai
pack template for custom analyzer (#10155)
2d924ca 
Fixes #9915

Context
#9789 added a template for custom analyzer.
In order for that to be usable by our customers - we need to be publishing this to nuget feed along with our other binaries. So we should have the package produced from our repo - ideally as part of our build script

Changes Made
Create a template package project with property <GeneratePackageOnBuild>true</GeneratePackageOnBuild>that pack the templates into a nuget package when build. Add the package project in the msbuild solution in order to build the project.

Testing
https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=9602998&view=artifacts&pathAsName=false&type=publishedArtifacts in the packageArtifacts folder.

image
@JaynieBai JaynieBai mentioned this issue Jul 9, 2024
Merged
JaynieBai added a commit that referenced this issue Aug 6, 2024
@JaynieBai
Sync Microsoft.Build version in analyzer template with Version.props …
705a282 
…in the workflow (#10345)

Fixes #9923

Context
#9789 added a template for custom analyzer. Microsoft.Build version specified in the template should be synced with Version.props during packing. See https://github.com/dotnet/msbuild/pull/9789/files#r1521218723 for more details.
This needs to be done after #9915.

Changes Made
Create a workflow. When there are updates in the file Version.props, the flow will be trigger and check the version. If the version in the template is different form the VersionPrefix in the Version.props. It will create a PR to sync the version between them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaynieBai JaynieBai

Labels
Area: BuildCheck
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pack template for custom analyzer dotnet/msbuild
3 participants
@GangWang01 @JanKrivanek @JaynieBai