Prevent Collection was modified; enumeration operation may not execute. #8959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anpete
reviewed
Jun 24, 2017
| @@ -607,7 +607,7 @@ private void DeleteFixup(InternalEntityEntry entry) | |||
| { | |||
| if (principalToDependent.IsCollection()) | |||
| { | |||
| var dependents = ((IEnumerable)navigationValue).Cast<object>(); | |||
| var dependents = ((IEnumerable)navigationValue).Cast<object>().ToList(); | |||
There was a problem hiding this comment.
Consider using ArrayList here to avoid allocating during Cast.
There was a problem hiding this comment.
ArrayList requires an ICollection, but we only have an IEnumerable
anpete
approved these changes
Jun 24, 2017
Issue #8101 Happens when entities are inconsistently fixed up and do shenanigans in setters. (May also happen in other scenarios, but I was able to repro it this way.) Fix is to do defensive copy.
ajcvickers
force-pushed
the
WhoMovedTheCheese0623
branch
from
4007aac to
1a223ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #8101
Happens when entities are inconsistently fixed up and do shenanigans in setters. (May also happen in other scenarios, but I was able to repro it this way.) Fix is to do defensive copy.