Query: Allow FromSql to accept parameter of type DbParameter in subquery #8885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
fromsqllostparameters8721
branch
from
51b6ff3 to
8168cec
Compare
smitpatel
commented
Jun 16, 2017
| if (parameterValues.TryGetValue(parameter.InvariantName, out var parameterValue)) | ||
| if (parameter is RawRelationalParameter) | ||
| { | ||
| parameter.AddDbParameter(command, value: null); |
There was a problem hiding this comment.
Since IRelationalParameter.AddDbParameter` has value parameter, passing null in this case.
There was a problem hiding this comment.
Change to polymorphic call on parameter
anpete
reviewed
Jun 19, 2017
|
|
||
| substitutions = new string[argumentValues.Length]; | ||
|
|
||
| for (var i = 0; i < argumentValues.Length; i++) | ||
| { | ||
| var value = argumentValues[i]; | ||
| if (value is DbParameter dbParameter) | ||
| { | ||
| substitutions[i] = dbParameter.ParameterName; |
There was a problem hiding this comment.
So this is to support {0} syntax with raw parameter?
anpete
reviewed
Jun 19, 2017
| { | ||
| substitutions[i] = dbParameter.ParameterName; | ||
| _relationalCommandBuilder.AddRawParameter(dbParameter.ParameterName, dbParameter); | ||
| continue; |
smitpatel
force-pushed
the
fromsqllostparameters8721
branch
2 times, most recently
from
f7a4e48 to
0bb07a9
Compare
|
@anpete - Ready for review Test patterns covered
cc: @divega - If you want to check out. |
smitpatel
changed the title
smitpatel
force-pushed
the
fromsqllostparameters8721
branch
from
0bb07a9 to
779da18
Compare
anpete
reviewed
Jun 21, 2017
| /// </summary> | ||
| public void AddDbParameter(DbCommand command, object value) | ||
| { | ||
| if (value == null) |
smitpatel
force-pushed
the
fromsqllostparameters8721
branch
2 times, most recently
from
65f366e to
78fceb9
Compare
Add RawRelationalParameter to flow user defined DbParameter to DbCommand Add method on IRelationalParameter which takes command and parameterValues Add RelationalParameterBase class FromSql when taking DbParameter arg - Use format item to substitute if available - Use named arg if no format item available - Generate a name if DbParameter.ParameterName is unspecified
smitpatel
force-pushed
the
fromsqllostparameters8721
branch
from
78fceb9 to
4c94662
Compare
|
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8721
TODO:
@anpete - Creating PR to get initial feedback on the approach.