Revert back to parameter logging format from v1 and update test baselines #8629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ines Issue #8456 We previously used a different format for parameter logging in our tests when compared to product code logging. Now we use the same format everywhere. This change updates the product format back to what it was, and updates the test baselines to reflect this.
divega
approved these changes
May 28, 2017
| @@ -989,7 +989,7 @@ public static TheoryData CommandActions | |||
| foreach (var item in log.Skip(1)) | |||
| { | |||
| Assert.EndsWith( | |||
| @"[Parameters=[FirstParameter: 17], CommandType='0', CommandTimeout='30'] | |||
| @"[Parameters=[FirstParameter='17'], CommandType='0', CommandTimeout='30'] | |||
There was a problem hiding this comment.
Nit: Did we ever consider not including CommandType in this case? I believe it will be 0 in not specified, although documentation says default is Table, neither is very interesting. Also, do we always log the numeric value or do we log the name of the enum member?
There was a problem hiding this comment.
@divega Don't know. We never set it, so it will always be zero, which is not a valid enum value and hence is shown like this. This was done a long time ago--I doubt it was really thought about, but I don't know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #8456
We previously used a different format for parameter logging in our tests when compared to product code logging. Now we use the same format everywhere. This change updates the product format back to what it was, and updates the test baselines to reflect this.