Standardize and consolidate logging #8136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lajones
reviewed
Apr 12, 2017
| @@ -76,7 +75,7 @@ protected DbContext() | |||
| : this(new DbContextOptions<DbContext>()) | |||
| { | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Remove extra whitespace here and a couple of places below.
Issues #7217 #218 This change: * Consolidates interception and sensitive logging into one service and uses that service everywhere in the EF code. * Adds a LoggerCategory class which contains nested classes that define EF logging categories. * Used together, this means any EF service can depend on `IInterceptingLogger<TLoggingCategory>` and have D.I. fill create the correct service using its open generics feature. The TLoggingCategory is constrained so that only types specifically defined as LoggingCategories can be used. For example, `IInterceptingLogger<LoggingCategory.Database.Sql>`. * Application code can get logging categories using, for example, `LoggingCategory.Database.Sql.Name`. This means that any application can immediately see in code what logging categories there are to do appropriate filtering. * All services depend on the specific generic `IInterceptingLogger<TLoggingCategory>` that they will use--never ILogger. This makes it very clear which category is being logged to and makes it safe to share loggers where safe, and impossible where the categories should be different.
ajcvickers
force-pushed
the
LoggyMcLogFace0405
branch
from
3b7459c to
599e9a7
Compare
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues #7217 #218
This change:
IInterceptingLogger<TLoggingCategory>and have D.I. create the correct service using its open generics feature. The TLoggingCategory is constrained so that only types specifically defined as LoggingCategories can be used. For example,IInterceptingLogger<LoggingCategory.Database.Sql>.LoggingCategory.Database.Sql.Name. This means that any application can immediately see in code what logging categories there are to do appropriate filtering.IInterceptingLogger<TLoggingCategory>that they will use--never ILogger. This makes it very clear which category is being logged to and makes it safe to share loggers where safe, and impossible where the categories should be different.