Query: Convert SetOperator.Source2 from EntityQueryable to QueryModel… #8061
Conversation
|
|
||
| if (querySourceReferenceExpression != null | ||
| && querySourceReferenceExpression.ReferencedQuerySource == groupJoinClause) | ||
| if (additionalFromClause?.FromExpression is QuerySourceReferenceExpression querySourceReferenceExpression && querySourceReferenceExpression.ReferencedQuerySource == groupJoinClause) |
There was a problem hiding this comment.
nit: formatting (add newline before &&)
| break; | ||
|
|
||
| case ConcatResultOperator concatResultOperator | ||
| when IsEntityQueryable(concatResultOperator.Source2): |
There was a problem hiding this comment.
nit: make indentations consistent
|
|
||
| private static SubQueryExpression ConvertEntityQueryableToSubQuery(Expression expression) | ||
| { | ||
| var mainFromClause = new MainFromClause("set_" + _setOperatorCount++, expression.Type.GenericTypeArguments[0], expression); |
There was a problem hiding this comment.
add some funky characters to the name that would prevent clashes, just like relinq does for their generated item names (e.g. "<set_1>") - and add suitable test
smitpatel
force-pushed
the
rawentityquerybleinset
branch
2 times, most recently
from
b4e9bf9 to
efece73
Compare
|
Updated. |
|
|
||
| private static bool IsEntityQueryable(Expression expression) | ||
| { | ||
| return expression is ConstantExpression constantExpression |
There was a problem hiding this comment.
is constantExpression guaranteed to be of generic type? Otherwise this line will throw. Maybe add defensive check.
There was a problem hiding this comment.
Done. Added check to verify if the type is generic.
There was a problem hiding this comment.
DRY this with other 3 places in stack.
There was a problem hiding this comment.
For reference #8074
smitpatel
force-pushed
the
rawentityquerybleinset
branch
from
efece73 to
41e3fba
Compare
smitpatel
force-pushed
the
rawentityquerybleinset
branch
2 times, most recently
from
6c29c70 to
71c2106
Compare
… when applicable. This causes issue when translating EntityQueryable to SelectExpression as there is no query source.
smitpatel
force-pushed
the
rawentityquerybleinset
branch
from
71c2106 to
52ac479
Compare
| private static SubQueryExpression ConvertEntityQueryableToSubQuery(Expression expression) | ||
| { | ||
| var mainFromClause = new MainFromClause( | ||
| $"<set>_{_setOperatorCount++}", |
There was a problem hiding this comment.
Use a better name? Type name
… when applicable.
This causes issue when translating EntityQueryable to SelectExpression as there is no query source.
resolves #7279