fix issue 7784. Remove extraneous IS NOT NULL checks on equals compa… #7804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmiddleton, |
pmiddleton
force-pushed
the
fix7784
branch
2 times, most recently
from
c718d11 to
2a15ce8
Compare
maumar
approved these changes
Mar 16, 2017
|
Merged in 42e8bbe, thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #7784.
RelationalNullsExpandingVisitor was adding an extra IS NOT NULL check when an equals comparison was performed on a nullable column. That check is only needed if a not equals comparison is being performed, or if NOT logic is involved on any of the parameters.