Query: Translate aggregate functions to server only if not on subquery #7694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anpete
approved these changes
Feb 23, 2017
| var nonNullableInputType = inputType.UnwrapNullableType(); | ||
| if (nonNullableInputType == typeof(int) | ||
| || nonNullableInputType == typeof(long)) | ||
| if (!(expression is SelectExpression)) |
There was a problem hiding this comment.
Does expression need RemoveConvert?
There was a problem hiding this comment.
Possibly. will update.
smitpatel
force-pushed
the
sumoversubquery3792
branch
from
98afdf5 to
7641163
Compare
smitpatel
force-pushed
the
sumoversubquery3792
branch
from
7641163 to
dcde6b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3792
Aggregate over subquery generates invalid sql. For Max/Min/Average/Sum if the inner projection is a subquery (aka selectexpresion) then we force client eval.