Add EF.Functions and SQL Like #7611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have just amended this PR. Aside from rebasing for VS2017 support, this PR now adds SQL LIKE support via Note that the SqlTranslatingExpressionVisitor had to be tweaked for it to allow translating method calls on the |
|
@roji Would you mind rebasing again? We renamed the world 😬 |
|
@anpete rebased, also renamed EFFunctions -> DbFunctions (looks slightly better). Let me know if you want any changes |
|
@roji I'm seeing some test failures in ApiConsistencyTest, can you take a look? BTW, sorry for the delay 😄 |
To allow relational and providers to start defining extension methods on it. Modify SqlTranslatingExpressionVisitor to recognize the EFFunctions class and translate methods on it. Relates to dotnet#2850
Both with and without an escape character. Relates to dotnet#2850
|
Fixed and rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow relational and providers to start defining extension methods on it, for #2850.
Hope this is more or less what you guys were thinking of, let me know of any nitpicks in terms of class/file naming etc.
Note that no actual methods (e.g. Like) are defined, that can come later in a separate PR.