Add support for SQL Server memory-optimized tables #6442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -264,10 +274,12 @@ public virtual IReadOnlyList<MigrationOperation> GetDifferences(IModel source, I | |||
| .Concat(dropTableOperations) | |||
| .Concat(dropOperations) | |||
| .Concat(dropColumnOperations) | |||
| .Concat(alterDatabaseOperations) | |||
There was a problem hiding this comment.
My gut feeling is that this should go just before createSequenceOperations.
There was a problem hiding this comment.
I have no objections
AndriySvyryd
force-pushed
the
InMemory
branch
2 times, most recently
from
bcb1900 to
9e723d8
Compare
| IEnumerable<IAnnotation> For([NotNull] IIndex index); | ||
| IEnumerable<IAnnotation> For([NotNull] IProperty property); | ||
| IEnumerable<IAnnotation> For([NotNull] IKey key); | ||
| IEnumerable<IAnnotation> For([NotNull] IForeignKey foreignKey); | ||
| IEnumerable<IAnnotation> For([NotNull] IEntityType entityType); | ||
| IEnumerable<IAnnotation> For([NotNull] ISequence sequence); | ||
|
|
||
| IEnumerable<IAnnotation> ForRemove([NotNull] IModel model); |
There was a problem hiding this comment.
Huh? The differ never generates DropDatabase operations...
There was a problem hiding this comment.
Oh interesting. It's a special AlterDatabase when you're going to InitialDatabase
|
👍 Looking good |
| /// This API supports the Entity Framework Core infrastructure and is not intended to be used | ||
| /// directly from your code. This API may change or be removed in future releases. | ||
| /// </summary> | ||
| public virtual bool IsMemoryOptimized |
There was a problem hiding this comment.
Given warning above, .Internal namespace?
There was a problem hiding this comment.
I'll remove the doc comment
AndriySvyryd
force-pushed
the
InMemory
branch
2 times, most recently
from
c994932 to
0c8532f
Compare
| bool oldNullable = false, | ||
| [CanBeNull] object oldDefaultValue = null, | ||
| [CanBeNull] string oldDefaultValueSql = null, | ||
| [CanBeNull] string oldComputedColumnSql = null) |
There was a problem hiding this comment.
I wonder if these should be grouped in the API. For example...
.AlterColumn(
oldColumn: new ColumnModel<int>(
isRequired: false));...or...
.AlterColumn()
.OldColumn<int>(
isRequired: flase);Might be worth discussing in a design meeting, but I also like the simplicity and consistency with Rename* of the way you have it.
|
|
Add ForSqlServerIsMemoryOptimized() EntityBuilder extension method Add support for conventions to run when an annotation is set Change conventions to not set cascade delete on foreign keys on memory-optimized tables Add convention to configure keys and indexes as nonclustered on memory-optimized tables Change IsClustered extension method on builders to take a bool? Add AlterDatabaseOperation and AlterTableOperation Add old values to all alter operations Add migrations annotations providers for IModel and ISequence Add migrations annotations providers for removed objects Set migrations annotations on drop operations Diff migrations annotations for IModel, IEntityType and ISequence Add support for memory-optimized tables to RelationalDatabaseCleaner Fixes #6405 Fixes #3122
AndriySvyryd
force-pushed
the
InMemory
branch
from
0c8532f to
326663a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ForSqlServerIsMemoryOptimized() EntityBuilder extension method
Add support for conventions to run on annotation set
Change conventions to not set cascade delete on foreign keys on on memory-optimized tables
Add convention to configure keys and indexes as nonclustered on memory-optimized tables
Change IsClustered extension method on builders to take a bool?
Add AlterDatabaseOperation and AlterTableOperation
Add OldAnnotations to all alter operations
Add migrations annotations providers for IModel and ISequence
Diff migrations annotations for IModel, IEntityType and ISequence
Set migrations annotations on drop operations
Add support for memory-optimized tables to RelationalDatabaseCleaner
Fixes #6405
Fixes #3122