Add support for data annotations on fields #6376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| var targetType = FindCandidateNavigationPropertyType(propertyInfo); | ||
| var propertyInfo = memberInfo as PropertyInfo; | ||
| var targetType = propertyInfo == null ? null : FindCandidateNavigationPropertyType(propertyInfo); |
There was a problem hiding this comment.
Split into two loops to avoid the double cast
There was a problem hiding this comment.
Tried this, but there is more code and it seems less readable, so made a minor change to not store targetType into a local but left as a single loop.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6316