Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for #3804 - Select Navigation following Skip or Take #5198

Merged
merged 1 commit into from
May 17, 2016
Merged

Add tests for #3804 - Select Navigation following Skip or Take #5198

merged 1 commit into from
May 17, 2016

Conversation

mikary
Copy link
Contributor

@mikary mikary commented Apr 27, 2016

@maumar
Copy link
Contributor

maumar commented Apr 28, 2016

you might want to hold of on this checkin - I just submitted a PR that adds better result verification for the navigation tests. I think we should take advantage of it for all the new tests that are being added

@divega
Copy link
Contributor

divega commented May 17, 2016

@maumar @mikary should we now revisit this PR?

@mikary
Copy link
Contributor Author

mikary commented May 17, 2016

@divega I've been looking into adding tests for a number of related issues (#3804 #3674 #3676 and #3913) that have been resolved (or partially resolved in the case of #3676) and adding tests for the scenarios described in the issues to avoid regressions. All of these tests would be in QueryNavigationsTestBase and I'm looking at consolidating all of these tests into one PR.

@mikary mikary force-pushed the skipTakeSelectNav branch from 980dc01 to 27bb90d Compare May 17, 2016 18:47
@mikary
Copy link
Contributor Author

mikary commented May 17, 2016

@maumar updated with tests for the listed issues

@maumar
Copy link
Contributor

maumar commented May 17, 2016

:shipit:

@mikary
Add tests for Navigation issues that no longer reproduce
de7c938 
Add test for #3804 - Select Navigation following Skip or Take
Add test for #3674 - GroupBy with Where on Navigation Property
Add test for #3676 - GroupBy Let on Navigation Property (disabled)
Add test for #3913 - Sum + Count inside Select
@mikary mikary force-pushed the skipTakeSelectNav branch from 27bb90d to de7c938 Compare May 17, 2016 22:33
@mikary mikary merged commit de7c938 into dev May 17, 2016
@mikary mikary deleted the skipTakeSelectNav branch May 17, 2016 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikary @maumar @divega @dnfclas