Navigation test refactoring initial work #35652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/EFCore.Specification.Tests/Query/Relationships/ComplexRelationshipsQueryFixtureBase.cs
Show resolved
Hide resolved
test/EFCore.Specification.Tests/Query/Relationships/ComplexRelationshipsQueryFixtureBase.cs
Outdated
Show resolved
Hide resolved
maumar
force-pushed
the
navigations_test_refactoring
branch
2 times, most recently
from
621497e to
8d1a4d6
Compare
maumar
force-pushed
the
navigations_test_refactoring
branch
3 times, most recently
from
64b65bd to
f42c629
Compare
|
Are you planning to replace the commented-out tests in this PR or a separate one? |
|
@AndriySvyryd this PR, I will add some more tests and do the clean-up of the commented ones. But you can take a look at the model and the test class structure. |
AndriySvyryd
approved these changes
Feb 27, 2025
maumar
force-pushed
the
navigations_test_refactoring
branch
2 times, most recently
from
16601a6 to
fac79bf
Compare
We want to be able to re-use existing navigation tests (currently spread around multiple test classes - complex navs, gears of war, northwind, json) for the upcoming optional complex types, complex collections and json-mapped complex types (all highly requested features in EF). We also want to be able to increase coverage for existing features, e.g. we have very good coverage of navigations in json test suite, but it's not used for regular or owned entities. This work can also be used by provider writers (e.g. Mongo) to boost their coverage. Navigation test refactoring: - using common model for entity, owned, json and complex type navigations - 4 levels: root, trunk, branch, leaf - optional reference, required reference (dependent to principal), collection - for now just testing projection scenarios as proof of concept (tracking / notracking) TODO: - fix owned sqlite model, - add model with inheritance, - move actual tests from existing test suites (ongoing), - add migration check (that model can be migrated to from scratch and that noop is actual noop), - implement InMemory tests. - added include stub - added cosmos tests
maumar
force-pushed
the
navigations_test_refactoring
branch
from
fac79bf to
e1cc089
Compare
roji
reviewed
Feb 28, 2025
|
|
||
| [ConditionalTheory] | ||
| [MemberData(nameof(IsAsyncData))] | ||
| public virtual Task Include_trunk_collection(bool async) |
There was a problem hiding this comment.
@maumar remember that as discussed, I think we want to keep tests which rely on collection relationships separate from those which only rely on reference relationships - this is because we have non-JSON complex/owned mapping (table splitting), which will only be supported with reference relationships.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We want to be able to re-use existing navigation tests (currently spread around multiple test classes - complex navs, gears of war, northwind, json)
for the upcoming optional complex types, complex collections and json-mapped complex types (all highly requested features in EF).
We also want to be able to increase coverage for existing features, e.g. we have very good coverage of navigations in json test suite, but it's not used for regular or owned entities.
This work can also be used by provider writers (e.g. Mongo) to boost their coverage.
Details:
TODO: