Basic setup of dev container. #35351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not necessarily pushing back, but is this useful without e.g. SQL Server and the ability to actually run tests? Who do we imagine would use this for compilation only? This also does add some maintenance burden on us, to keep things up to date etc. (not much, but still). |
|
If you run the dev container locally (not in codespaces), you can still connect to your local DBs, same as today. My plan is to add containers with DBs eventually later. |
roji
approved these changes
Dec 19, 2024
|
related to #27483 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is just the environment to build everything. No capability to do testing directly in the dev container. We can add those items later, based on the feedback/requests (especially regarding usage in GitHub Codespaces).