Refactor reverse engineering API #3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
force-pushed
the
namc/design
branch
2 times, most recently
from
5d7813c to
5e97383
Compare
| @@ -1 +1 @@ | |||
| // Unable to generate EntityType TableWithUnmappablePrimaryKeyColumn. Unable to identify any primary key columns in the underlying SQL Server table [dbo].[TableWithUnmappablePrimaryKeyColumn]. | |||
| // Unable to generate EntityType TableWithUnmappablePrimaryKeyColumn. Unable to identify the primary key for table 'TableWithUnmappablePrimaryKeyColumn'. | |||
There was a problem hiding this comment.
Please include the schema name for SQL Server tables.
|
|
with agreed changes.
natemcmaster
force-pushed
the
namc/design
branch
3 times, most recently
from
811b710 to
61c9856
Compare
This splits reverse engineering at several levels. The entry point for provider writers is MetadataModelProvider.GetModel(). The framework provides some implementation helpers. - MetadataModelProvider has a protected method 'AddNavigationProperties' which should be called on a mostly-ready IModel. This will add navprops for all foreign keys. - Providers can implement RelationalMetadataModelProvider. If given SchemaInfo and a type mapper, it will build and IModel. - Providers can override methods in RelationalMetadataModelProvider to get specific control over how metadata is build, if the default is unsuitable.
natemcmaster
force-pushed
the
namc/design
branch
from
61c9856 to
f773fb4
Compare
natemcmaster
pushed a commit
that referenced
this pull request
Oct 16, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits reverse engineering at several levels. The entry point for provider writers is
MetadataModelProvider.GetModel().The framework provides some implementation helpers.
MetadataModelProviderhas a protected methodAddNavigationPropertieswhich should be called on a mostly-readyIModel. This will add navprops for all foreign keys.RelationalMetadataModelProvider. If givenSchemaInfoand a type mapper, it will build andIModel.RelationalMetadataModelProviderto get specific control over how metadata is build, if the default is unsuitable.Closes #3404, #3077, #3288, #3247 and #3329.
TODO
[ ] also update how a provider passes their
UseProvider()method name to the code gen step.[ ] move everything to M.D.E.Scaffolding (.Internal)