Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commands: Don't require ef.exe to be copied to the output directory #6916

Closed
bricelam opened this issue Nov 1, 2016 · 0 comments
Closed

Commands: Don't require ef.exe to be copied to the output directory #6916

bricelam opened this issue Nov 1, 2016 · 0 comments
Assignees
@bricelam
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
tools/1.0.0-msbuild3

Comments

@bricelam
Copy link
Contributor

bricelam commented Nov 1, 2016 •
edited
Loading

If we use AppDomain.AssemblyResolve when --no-appdomain is specified, it would avoid the need to copy ef.exe into the output directory. This includes when we copy it in the NuGet commands for UWP projects.
@bricelam bricelam self-assigned this Nov 1, 2016
@rowanmiller rowanmiller added this to the 1.2.0 milestone Nov 1, 2016
@bricelam bricelam added the tools label Nov 2, 2016
@bricelam bricelam changed the title Commands: Use AppDomain.AssemblyResolve when --no-appdomain Commands: Don't require ef.exe to be copied to the output directory Nov 2, 2016
@bricelam bricelam mentioned this issue Nov 4, 2016
Merged
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 4, 2016
@bricelam bricelam closed this as completed Nov 8, 2016
bricelam added a commit to aspnet/EntityFramework.Tools that referenced this issue Nov 9, 2016
@bricelam
Update EntityFrameworkCore.psm1
b10e3e9 
Notable changes:
* Remove Use-DbContext
* Allow -From and -To as positional arguments on Script-Migration
* Remove support for xproj
* Remove --config option from ef.exe
* Hook AppDomain.AssemblyResolve when --no-appdomain

Resolves dotnet/efcore#5471, resolves dotnet/efcore#6916

# Conflicts:
#	src/Microsoft.EntityFrameworkCore.Tools.DotNet/project.json
#	src/Microsoft.EntityFrameworkCore.Tools/project.json
#	src/Microsoft.EntityFrameworkCore.Tools/tools/EntityFrameworkCore.psm1
@bricelam bricelam mentioned this issue Nov 18, 2016
Closed
@bricelam bricelam modified the milestones: 1.2.0, tools-1.0.0 Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
tools/1.0.0-msbuild3
Development

No branches or pull requests
2 participants
@bricelam @rowanmiller