Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Can't always override RelationalQueryableMethodTranslatingExpressionVisitor #17156

Closed
bricelam opened this issue Aug 14, 2019 · 1 comment
Closed

Query: Can't always override RelationalQueryableMethodTranslatingExpressionVisitor #17156

bricelam opened this issue Aug 14, 2019 · 1 comment
Assignees
@smitpatel
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
3.0.0

Comments

@bricelam
Copy link
Contributor

bricelam commented Aug 14, 2019 •
edited
Loading

This line creates a RelationalQueryableMethodTranslatingExpressionVisitor directly and doesn't let the provider use its own implementation.
@ajcvickers ajcvickers self-assigned this Aug 16, 2019
@ajcvickers ajcvickers added this to the 3.0.0 milestone Aug 16, 2019
@ajcvickers
Copy link
Contributor

Try using a factory.

@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog Aug 19, 2019
@smitpatel smitpatel modified the milestones: Backlog, 3.0.0 Aug 20, 2019
@smitpatel smitpatel added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed punted-for-3.0 labels Aug 20, 2019
@smitpatel smitpatel assigned smitpatel and unassigned ajcvickers Aug 20, 2019
smitpatel added a commit that referenced this issue Aug 20, 2019
@smitpatel
Query: Allow providers to create subquery translating visitor
f99c8e4 
Fixes #17156
@smitpatel smitpatel mentioned this issue Aug 20, 2019
Merged
smitpatel added a commit that referenced this issue Aug 20, 2019
@smitpatel
Query: Allow providers to create subquery translating visitor
ba5c3f7 
Fixes #17156
smitpatel added a commit that referenced this issue Aug 21, 2019
@smitpatel
Query: Allow providers to create subquery translating visitor
045c5bb 
Fixes #17156
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@bricelam @ajcvickers @smitpatel