Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move discriminator support to Core #13603

Closed
AndriySvyryd opened this issue Oct 11, 2018 · 5 comments
Closed

Move discriminator support to Core #13603

AndriySvyryd opened this issue Oct 11, 2018 · 5 comments
Assignees
@smitpatel
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.0.0

Comments

@AndriySvyryd
Copy link
Member

This would allow easier implementations of discriminators in non-relational providers
@ajcvickers ajcvickers added this to the 3.0.0 milestone Oct 12, 2018
@ajcvickers
Copy link
Contributor

Do the move, not enhancing the API. (Unless we do need to do that.)

AndriySvyryd pushed a commit that referenced this issue May 14, 2019
@ajcvickers @AndriySvyryd
Add Cosmos metadata extensions for conventions
d4b0d9d 
Move Discriminator metadata to Core

Part of #214
Part of #13603
@AndriySvyryd AndriySvyryd mentioned this issue May 14, 2019
Merged
AndriySvyryd pushed a commit that referenced this issue May 14, 2019
@ajcvickers @AndriySvyryd
Add Cosmos metadata extensions for conventions
5c92ef8 
Move Discriminator metadata to Core

Part of #214
Part of #13603
@AndriySvyryd
Copy link
Member Author

AndriySvyryd commented May 14, 2019 •
edited
Loading

Metadata moved to Core. Common Query parts still need to be moved (e.g. the materializer).

AndriySvyryd pushed a commit that referenced this issue May 14, 2019
@ajcvickers @AndriySvyryd
Add Cosmos metadata extensions for conventions
3637d8a 
Move Discriminator metadata to Core

Part of #214
Part of #13603
@smitpatel
Copy link
Contributor

@AndriySvyryd - Can you take a quick look and tell what parts need to be moved from query? Query's materializer utilizes TPH at core level. The only pending thing would be InMemory, but InMemory needs to change it's storage strategy to align with TPH.

@AndriySvyryd
Copy link
Member Author

I think that's enough for now. If some other common pattern appears we can move it later.

@smitpatel
Copy link
Contributor

Fixed by #15809

@smitpatel smitpatel modified the milestones: 3.0.0, 3.0.0-preview6 Jun 19, 2019
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 19, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview6, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@ajcvickers @smitpatel @AndriySvyryd