This repository was archived by the owner on Aug 2, 2023. It is now read-only.
Add more cancellation tests #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Apr 20, 2017
| Pipe.Writer.WriteAsync(new byte[] {}); | ||
| Pipe.Reader.CancelPendingRead(); | ||
|
|
||
| Assert.True(awaitable.IsCompleted); |
There was a problem hiding this comment.
Why isn't this assert in the other test?
halter73
reviewed
Apr 20, 2017
| awaitable.OnCompleted(() => {}); | ||
|
|
||
| Pipe.Reader.Advance(Pipe.Reader.ReadAsync().GetResult().Buffer.End); | ||
| Pipe.Writer.CancelPendingFlush(); |
There was a problem hiding this comment.
I think it makes sense to test flipping the order of the above two lines to verify Advance won't clobber the canceled state.
halter73
approved these changes
Apr 20, 2017
cesarblum
reviewed
Apr 21, 2017
| @@ -215,6 +215,44 @@ public void FlushAsyncCompletedAfterPreCancellation() | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void FlushAsyncReturnsIsCancelOnCancelPendingFlushBeforeGetResult() | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.