Adding missing typeforward for Lazy<T,TMetadata> to S.CM.Composition

[maryamariyan]

Adding missing typeforward for Lazy<T,TMetadata> to System.ComponentModel.Composition

Fixes #27299

[maryamariyan]

This PR needs work. This wouldn't work for netfx.

[weshaggard]

You are going to need to #ifdef this and include it only for netcoreapp, and for the other configurations you will need to include the API for Lazy<T,M> in the ref.

[maryamariyan]

Thanks @weshaggard

[weshaggard]

Sorry your comment about netfx through me off but after looking at the configurations more closely you don't need to #ifdef this you should always have the type-forward here.

As for the netfx build issue you need to fix it by adding a "_netfx" configuration in the src project for this library. However when you do that you will start having test failures because of https://github.com/dotnet/corefx/issues/25781 so you can either tackle that issue now or temporarily add a "_netfx" placeholder configuration in the test project as well.

[weshaggard]

While looking at the pkgproj I also noticed https://github.com/dotnet/corefx/blob/master/src/System.ComponentModel.Composition/pkg/System.ComponentModel.Composition.pkgproj#L13,L15 which isn't necessary and should be removed.

[joperezr]

Assuming you'll add the _netfx configurations to src and tests as we discussed offline this LGTM.

[weshaggard]

Looks like the binary serialization tests are failing to find the assembly. We many need to make some tweaks to those tests to fix them when running on netfx. @ViktorHofer any ideas on how those tests look for the assembly?

[ViktorHofer]

The following two exceptions types are causing the FileNotFoundException:

• CompositionContractMismatchException
• ImportCardinalityMismatchException

both from System.ComponentModel.Composition. The test isn't doing anything fancy. I can repro the issue just by calling the ctor of one of the types:

[Fact]
public void X()
{
    var exception = new Exception();
    var x = new System.ComponentModel.Composition.CompositionContractMismatchException("message", exception);
}

In my environment there is no System.ComponentModel.Composition.dll in ~\git\corefx2\bin\runtime\netfx-Windows_NT-Debug-x64.

Building the project with netfx results in the following error:

~:\git\corefx2\src\System.ComponentModel.Composition\src>msbuild /t:Rebuild /v:m /p:TargetGroup=netfx
Microsoft (R) Build Engine version 15.5.180.51428 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

~\git\corefx2\Tools\ApiCompat.targets(56,5): error : TypesMustExist : Type 'System.Lazy<T, TMetadata>' does not exist
in the implementation but it does exist in the contract. [~\git\corefx2\src\System.ComponentModel.Composition\src\Syst
em.ComponentModel.Composition.csproj]
~\git\corefx2\Tools\ApiCompat.targets(70,5): error : ApiCompat failed for '~\git\corefx2\bin\AnyOS.AnyCPU.Debug\Syste
m.ComponentModel.Composition\netstandard\System.ComponentModel.Composition.dll' [~\git\corefx2\src\System.ComponentMod
el.Composition\src\System.ComponentModel.Composition.csproj]

[joperezr]

In my environment there is no System.ComponentModel.Composition.dll

This is expected since what we are doing in this change is stop producing it. That is what the _netfx Configuration does.

Building the project with netfx results in the following error:

Again, this is expected, that is why we intentionally want to skip the build of this project on the netfx configuration.

@ViktorHofer shouldn't your tests pick up the System.ComponentModel.Composition.dll on the GAC for netfx?

[weshaggard]

There are a couple of issues with this change I'm making some tweaks locally and will push them once I validate.

[ViktorHofer]

If you need me to step in again, just ping me.

[weshaggard]

Thanks @ViktorHofer I've fixed the serialization tests. I'm just investigating the apicompat issues in all configurations.

[maryamariyan]

Thanks @weshaggard and @ViktorHofer.

[weshaggard]

@maryamariyan I pushed a few commits which should fix some these issues.

[weshaggard]

We still seem to be hitting some kind of apicompat issue. I didn't hit it on my rebuild locally but I'm trying a clean build to see if I can repro it.

[weshaggard]

OK I pushed a new commit as I believe I found the reason the netstandard configuration wasn't building correctly.

[danmoseley]

Wes couldn't you have just done

<Reference Include="@(NetStandardRefs)" Condition="'%(Identity)' != 'System.ComponentModel.Composition'">

[weshaggard]

Yes but that doesn't scale as nicely if we need to add more to the list.

[weshaggard]

Pushed one more change to fix the all configurations build for netcoreapp2.0.

[weshaggard]

test Alpine.3.6 x64 Debug Build
test OSX x64 Debug Build