-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update to ASP.NET Core shared framework 2.1.0-preview1-28031 #8341
Conversation
Update downloaded installers and wixlib to pull the ASP.NET Core Runtime (aka shared framework)
Test failures:
How do I update these builds to install NodeJS?
@JunTaoLuo any idea what we need to do to support Alpine Linux? I don't know if our native dependencies (libuv/sqlite) support musl-based Linux distros.
@JunTaoLuo does our portable linux-x64 build support these OSes? |
@livarcocc why is RHEL6 is building with |
@janvorli |
@natemcmaster |
@johnbeisner Ah. I think I'm using the wrong variable. I have CoreSetupRid, not SharedFrameworkRid.....will update |
@johnbeisner I'm still getting SharedFrameworkRid == |
I've updated the tests to skip NodeJS, and fixed the issues in building for RHEL 6 and Alpine. |
@natemcmaster Ubuntu failure seems legit:
|
@livarcocc I just pushed an update to use aspnet 2.1.0-preview1-28031 which includes our aspnet's debian agnostic installers. |
@livarcocc prior to pushing the 28031 update to the PR, the build log failure was this:
Do we need to have the transitive closure of debian packages available in order to build with the aspnetcore debian packages? If so, this will cause a coherence issue since dotnet/CLI currently consumes core-setup deb installers directly, and aspnetcore's deb installers also reference core-setup, but is not guaranteed to be the same version |
<AspNetCoreRuntimePackageBrandName>aspnetcore-store</AspNetCoreRuntimePackageBrandName> | ||
<AspNetCoreRuntimePackageFolderName>dev-26623</AspNetCoreRuntimePackageFolderName> | ||
<AspNetCoreRuntimePackageVersion>2.1.0-preview1-26623</AspNetCoreRuntimePackageVersion> | ||
<AspNetCoreVersion>$(MicrosoftAspNetCoreAppPackageVersion)</AspNetCoreVersion> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
build/compile/LzmaArchive.targets
Outdated
</PropertyGroup> | ||
|
||
<Target Name="GetNuGetPackagesArchive" | ||
Inputs="$(IntermediateArchive)" | ||
Outputs="$(FinalArchive)" | ||
Condition=" '$(IncludeNuGetPackageArchive)' == 'true' "> | ||
<DownloadFile Uri="$(NugetPackagesArchiveBlobUrl)$(CoreSetupBlobAccessTokenParam)" | ||
<DownloadFile Uri="$(NugetPackagesArchiveBlobUrl)" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@natemcmaster In your evaluation does the coherence check still work correctly? |
Yes, I've looked at it. I believe it works...though I haven't verified this with an actual coherent version of aspnetcore yet. |
https://ci.dot.net/job/dotnet_cli/job/master/job/debug_windows_nt_es_x64_prtest/529/ appears to be hung. What's the right dotnet-bot incantation to restart a PR build for one leg? |
@dotnet-bot test Windows_NT_ES x64 Debug Build |
@livarcocc @johnbeisner CI checks are green now. Ok to merge? |
Thanks for working through this @natemcmaster. |
The RHEL 6 cannot use portable build of the runtime, since the versions of various shared libraries we depend on are too old to be usable with the portable build. That's why the RHEL 6 version of coreclr is non-portable. |
In 2.1.0, ASP.NET Core is replacing the runtime package store with a shared framework, similar to Microsoft.NETCore.App. This PR updates packages and installers to pull the sharedfx instead of the runtime store.
In this PR:
Not in this PR: