Deduplicate assets produced on multiple build legs in the VMR to only be produced on the 'primary' build leg #60792
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-infrastructure
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
am11
reviewed
Mar 7, 2025
| - If we're building outside of the VMR, publish these assets from the Windows job. | ||
| - If we're building inside the VMR, publish these assets from whichever job is producing non-RID-specific artifacts. | ||
| --> | ||
| <PublishAllBuildsAssetsInThisJob Condition="('$(OS)' == 'Windows_NT' and '$(DotNetBuildOrchestrator)' != 'true') |
There was a problem hiding this comment.
Have we considered that some npm packages using gyp stuff (native libs) are platform specific? In a long dependency chain, chances of such an npm cannot be ignored.
There was a problem hiding this comment.
As far as I know, ASP.NET Core has been shipping the npms from their Windows build for years now and there hasn't been an issue. If one arises, then we can address this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deduplidate assets produced on multiple build legs in the VMR
As part of moving way from a "primary" vertical concept in the VMR, we need to deduplicate the Java and NPM assets that aspnetcore produces in the VMR builds. This PR provides that infrastructure.
Description
Changes the version files, Java artifacts, and NPM artifacts to all be published in the VMR only when we're publishing all artifacts, not only RID-specific ones.
Contributes to dotnet/source-build#4905