Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double line in APIReviewPrinciples.md for markdownlint #59891

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jan 16, 2025

#59883 failed because of double blank lines reported by markdownlint:

Error: docs/APIReviewPrinciples.md:9 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
Error: Process completed with exit code 1.

File was recently added here: #59880

I don't know why lint didn't complain on the PR but did complain on the dependency update 🤷 Edit: It did fail on the PR it was added, but it's not a required check.

cc @mkArtakMSFT

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 16, 2025
@JamesNK JamesNK requested a review from wtgodbe January 16, 2025 02:16
@JamesNK JamesNK merged commit dc2a6fe into main Jan 16, 2025
23 checks passed
@JamesNK JamesNK deleted the JamesNK-patch-1 branch January 16, 2025 05:04
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Jan 16, 2025
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants