[release/9.0] Fix MultipartReaderStream synchronous read when using buffer offset #59422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
BrennanConroy,
halter73 and
captainsafia
as code owners
dotnet-issue-labeler
bot
added
the
area-networking
BrennanConroy
added
Servicing-consider
dotnet-policy-service
bot
added
the
pending-ci-rerun
wtgodbe
approved these changes
Jan 7, 2025
This was referenced Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #59360 to release/9.0
/cc @BrennanConroy
Fix MultipartReaderStream synchronous read when using buffer offset
Description
When synchronously reading a multipart section and using a non-zero offset value for the passed in buffer, we incorrectly ignored the offset and would write into the buffer starting at the beginning. This would overwrite previous data in the buffer which corrupts the user payload.
Fixes #59269
Customer Impact
Corrupted buffer data for a multipart section.
Regression?
Regressed in 9.0
Risk
Silly error around not using the buffer
offset. Added missing test coverage.Verification
Packaging changes reviewed?