Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0] Fix IIS outofprocess to remove WebSocket compression handshake #58931

Merged
merged 8 commits into from
Nov 27, 2024
Merged

[release/9.0] Fix IIS outofprocess to remove WebSocket compression handshake #58931

merged 8 commits into from
Nov 27, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 13, 2024 •
edited by BrennanConroy
Loading

Backport of #58846 to release/9.0

/cc @BrennanConroy

Fix IIS outofprocess to remove WebSocket compression handshake

Description

Blazor enabled websocket compression by default in some cases. IIS OutOfProcess is a hosting model some customers use and it is not compatible with websocket compression.

Fixes https://github.com/dotnet/AspNetCore-ManualTests/issues/2688

Customer Impact

Using IIS OutOfProcess with Blazor Server-side/Interactive will not work.

Regression?

  • Yes
  • No

Regression from 8.0

Risk

  • High
  • Medium
  • Low

Added automated testing and did manual testing. Fix is fairly simple change.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Nov 13, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0.x milestone Nov 13, 2024
@BrennanConroy BrennanConroy added the ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. label Nov 13, 2024
@BrennanConroy BrennanConroy mentioned this pull request Nov 13, 2024
Closed
@lextm lextm mentioned this pull request Nov 14, 2024
Closed
@BrennanConroy BrennanConroy added Servicing-approved Shiproom has approved the issue and removed ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. labels Nov 14, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Nov 26, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Nov 27, 2024
@wtgodbe
Copy link
Member

wtgodbe commented Nov 27, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@captainsafia @wtgodbe
Skip WebSocketOutOfProcessTests on Windows.Amd64.Server2022.Open (#59112
d086eec 
)

* Skip WebSocketOutOfProcessTests on Windows.Amd64.Server2022.Open

* Use if-def from base class

* Fix in-proc and remove attributes from abstract class
@wtgodbe wtgodbe merged commit 401ae7c into release/9.0 Nov 27, 2024
25 checks passed
@wtgodbe wtgodbe deleted the backport/pr-58846-to-release/9.0 branch November 27, 2024 23:59
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 9.0.x, 9.0.1 Nov 28, 2024
This was referenced Jan 15, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@mgravell mgravell Awaiting requested review from mgravell mgravell is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-approved Shiproom has approved the issue
Projects
None yet
Milestone
9.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@wtgodbe @BrennanConroy @captainsafia