Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Microsoft.AspNetCore.Mvc.Testing RedirectHandler HasBody doesn't work with PATCH #58269

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix: Microsoft.AspNetCore.Mvc.Testing RedirectHandler HasBody doesn't work with PATCH #58269

merged 1 commit into from
Oct 9, 2024

Conversation

whoaskedfrfr
Copy link
Contributor

@whoaskedfrfr whoaskedfrfr commented Oct 7, 2024 •
edited
Loading

fix: Microsoft.AspNetCore.Mvc.Testing RedirectHandler HasBody doesn't work with PATCH

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Related #58270

Description

RedirectHandler doesn't work with Patch requests has it doesn't copy their body.

Fixes #{bug number} (in this specific format)

@whoaskedfrfr whoaskedfrfr requested a review from a team as a code owner October 7, 2024 14:18
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Oct 7, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 7, 2024
@martincostello martincostello added the feature-mvc-testing MVC testing package label Oct 7, 2024
@captainsafia captainsafia merged commit 80ac2ff into dotnet:main Oct 9, 2024
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Oct 9, 2024
captainsafia pushed a commit that referenced this pull request Dec 31, 2024
@whoaskedfrfr @captainsafia
fix: Microsoft.AspNetCore.Mvc.Testing RedirectHandler HasBody is miss…
dd2a3e1 
…ing PATCH (#58269)
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
@whoaskedfrfr @captainsafia
fix: Microsoft.AspNetCore.Mvc.Testing RedirectHandler HasBody is miss…
8e69343 
…ing PATCH (#58269)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member feature-mvc-testing MVC testing package
Projects
None yet
Milestone
10.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@whoaskedfrfr @captainsafia @martincostello