Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate local development scenarios in CI #57492

Merged
merged 7 commits into from
Aug 27, 2024

Conversation

MackinnonBuck
Copy link
Member

@MackinnonBuck MackinnonBuck commented Aug 23, 2024

Adds a check to ensure that local development scenarios are not broken:

  • Build and pack (Debug)
  • Build and pack (Release)
  • Run project template tests
    • These depend on the locally built shared framework being available
    • Currently all project template tests are run, but we could speed up this check a bit by limiting this to a smaller subset of tests (e.g., Blazor tests only)

This check can be further extended with additional scenarios as we see fit.

Fixes #56237

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 23, 2024
@MackinnonBuck
Copy link
Member Author

Looks like we're required to specify a minor and patch version when installing the JDK. This is hardcoded right now, as it is in helix. See also: #57476

@MackinnonBuck MackinnonBuck marked this pull request as ready for review August 26, 2024 21:43
@MackinnonBuck MackinnonBuck requested review from a team as code owners August 26, 2024 21:43
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you run an internal build against this branch to confirm the ci.yml changes didn't bust anything? Just push the branch to https://dev.azure.com/dnceng/internal/_git/dotnet-aspnetcore & queue a build of https://dev.azure.com/dnceng/internal/_build?definitionId=21 against that branch

@MackinnonBuck
Copy link
Member Author

The internal build passed; I'm going to merge this now.

@MackinnonBuck MackinnonBuck merged commit a94b1b7 into main Aug 27, 2024
28 checks passed
@MackinnonBuck MackinnonBuck deleted the mbuck/validate-local-dev-in-ci branch August 27, 2024 16:09
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate local development workflows in CI
2 participants