Upgrade xunit version to 2.9.0 #57303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
requested review from
BrennanConroy,
halter73,
JamesNK,
mgravell,
captainsafia,
a team,
brunolins16,
javiercn and
wtgodbe
as code owners
dotnet-issue-labeler
bot
added
the
area-infrastructure
akoeplinger
force-pushed
the
upgrade-xunit
branch
from
220ee20 to
cbfce49
Compare
akoeplinger
commented
Aug 14, 2024
mgravell
reviewed
Aug 14, 2024
JamesNK
reviewed
Aug 15, 2024
...server/SignalR/test/Microsoft.AspNetCore.SignalR.Tests/HubConnectionHandlerTests.Activity.cs
Outdated
Show resolved
Hide resolved
...ers/IIS/IntegrationTesting.IIS/src/Microsoft.AspNetCore.Server.IntegrationTesting.IIS.csproj
Show resolved
Hide resolved
...server/SignalR/test/Microsoft.AspNetCore.SignalR.Tests/HubConnectionHandlerTests.Activity.cs
Outdated
Show resolved
Hide resolved
|
For http/3 failure: #57373 |
JamesNK
approved these changes
Aug 21, 2024
This was referenced Aug 21, 2024
captainsafia
approved these changes
Aug 22, 2024
|
I think this is ready to merge, let me know if you prefer squash or a merge commit. |
|
We prefer squash commits in aspnetcore, merge commits are only enabled right now so that inter-branch merge PRs can be merge-committed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same process as last time: #43598
This upgrades xunit to the latest 2.9.0 version, matching what we use in arcade.
New xunit analyzers caught a lot of issues in the tests, those are now fixed. I recommend reviewing commit by commit.
Some warnings were suppressed where it made sense to me but please double check.