Propagate PropertyInfo for AsParameters parameters

[jgarciadelanoceda]

Propagate PropertyInfo for AsParameters parameters

Fixes the issue #56764

It adds the ContainerType for AsParameters parameters to be able to solve the issue in SwashBuckle OpenApi documentation with XML comments

[jgarciadelanoceda]

@dotnet-policy-service agree

[captainsafia]

Looks good! Left a few more comments to make the way we construct model metadata for parameters more resilient in the future.

[jgarciadelanoceda]

Looks good! Left a few more comments to make the way we construct model metadata for parameters more resilient in the future.

@captainsafia were you able to see the response? I had the same idea but the ParameterInfo does not contain the ContainerType and also the reportedType will not be the same in the case I change to ParameterInfo( for Types that have a TryParse method)

[captainsafia]

@jgarciadelanoceda Sorry for the delay...I needed a little bit of time to grok what you meant in your message.

This was my first thought indeed but the forParamater does not include the Container type (Because the ParameterInfo doesn't either)

The proposed change was for the else case of the change where we try to generate ModelMetadata for a parameter that doesn't have AsParameters. It seems like not having the ContainerType there is fine?

and also the logic in GetBindingSource and name gets other type that could be different from the type that the paramater has(for example when the type has a tryParse) and for compability issues I opted to just report the ParameterInfo

I see what you mean here. There is however an overload of ModelMetadataIdentity.ForParmaeter that takes ParameterInfo and Type (ref). I think that should do the trick?

[jgarciadelanoceda]

Finally it worked inserting a new line in ForParameter method :), checking if the Member is a PropertyInfo and Propagating the ContainerType of that PropertyInfo

[captainsafia]

LGTM! Thanks for iterating until we landed on a good spot.

[captainsafia]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).