Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hpack decoding test #57221

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Add hpack decoding test #57221

merged 2 commits into from
Aug 20, 2024

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Aug 7, 2024

There's a note in section 4.4 of the spec that an incoming header field can reference a dynamic table entry (i.e. for its name) that will be evicted as the incoming header field is inserted into the dynamic table. Add a test validating that we do something sensible in this case.

@amcasey
Add hpack decoding test
df74576 
There's a note in section 4.4 of the spec that an incoming header field can reference a dynamic table entry (i.e. for its name) that will be evicted as the incoming header field is inserted into the dynamic table.  Add a test validating that we do something sensible in this case.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Aug 7, 2024
@gfoidl gfoidl added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Aug 8, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Aug 20, 2024
@amcasey amcasey merged commit 85b528b into dotnet:main Aug 20, 2024
26 checks passed
@amcasey amcasey deleted the HpackDangling branch August 20, 2024 14:48
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Aug 20, 2024
@eerhardt eerhardt mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesNK JamesNK JamesNK approved these changes

@BrennanConroy BrennanConroy BrennanConroy approved these changes

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Milestone
10.0-preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@amcasey @JamesNK @BrennanConroy @gfoidl