Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in variable name: hasExplictValue -> hasExplicitValue #56981

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Fix typo in variable name: hasExplictValue -> hasExplicitValue #56981

merged 1 commit into from
Jul 25, 2024

Conversation

voroninp
Copy link
Contributor

@voroninp voroninp commented Jul 24, 2024

Fix typo in variable name

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

I was looking at the source code and noticed there's a typo: hasExplictValue but should be hasExplicitValue.

@voroninp voroninp requested a review from javiercn as a code owner July 24, 2024 21:25
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Jul 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 24, 2024
@voroninp
Copy link
Contributor Author

@mkArtakMSFT , hm... I'm surprised to see failed tests =)

@amcasey
Copy link
Member

amcasey commented Jul 25, 2024

Failure is in Microsoft.AspNetCore.SignalR.StackExchangeRedis.Tests.RedisEndToEndTests.CanSendAndReceiveUserMessagesFromMultipleConnectionsWithSameUser(transportType: LongPolling, protocolName: "messagepack"), which is tracked by #55954

@amcasey amcasey enabled auto-merge (squash) July 25, 2024 15:39
@amcasey amcasey merged commit d98caa8 into dotnet:main Jul 25, 2024
26 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-rc1 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants