Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add README to Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation package #54508

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Add README to Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation package #54508

merged 2 commits into from
Aug 22, 2024

Conversation

lyndaidaii
Copy link
Contributor

{PR title}

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

@lyndaidaii lyndaidaii requested a review from a team as a code owner March 12, 2024 18:54
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 12, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 12, 2024
captainsafia
captainsafia reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Similar question to my comment in the other repo: do we have to name this PACKAGE.md and have this in this directory?

@mkArtakMSFT mkArtakMSFT removed the community-contribution Indicates that the PR has been added by a community member label Mar 20, 2024
@mkArtakMSFT mkArtakMSFT self-assigned this Mar 20, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Mar 28, 2024
@halter73 halter73 changed the title add readme for package Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation Add README to Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation package Aug 22, 2024
@halter73 halter73 enabled auto-merge (squash) August 22, 2024 21:03
@halter73 halter73 removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Aug 22, 2024
@halter73 halter73 merged commit 6438c2f into dotnet:main Aug 22, 2024
22 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Aug 22, 2024
@MackinnonBuck MackinnonBuck mentioned this pull request Sep 12, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia left review comments

@mkArtakMSFT mkArtakMSFT mkArtakMSFT left review comments

@halter73 halter73 halter73 approved these changes

Assignees

@mkArtakMSFT mkArtakMSFT

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
10.0-preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@lyndaidaii @halter73 @captainsafia @mkArtakMSFT