-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please include deleting ASP.NET Core Runtime in Uninstaller #3286
Comments
From @leecow on June 29, 2018 15:44 @JunTaoLuo - can you have a look and move this issue to the right repo? |
@joeloff can you investigate why uninstalling the runtime did not remove the files under Microsoft.AspNetCore.App? |
From @joeloff on June 29, 2018 22:6 What exactly is installed on the machine? The ASP.NET shared framework ships in multiple ways
For 1 & 2, the same MSI would be ref counted against all bundles (EXEs) to avoid removing it if another bundle is still installed. The setup logs should be able to shed some light on why the MSI was skipped. Also, if the CLI marks the MSI as a permanent component, it won't remove it. |
Actually, although this is the most appropriate repo for this discussion, I should probably move it to Home as that's a public repo. |
We followed the Links from the blog post .NET Core 2.1 June Update and installed the SDK 64bit To remove it: Control Panel --> Programs and Features --> Microsoft .NET Core SDK 2.1.301 ---> Uninstall Do you need anything else? Where are the logs located? Just tell me what I can do to help you. (We had around 10 Devs with the very same problem) Is there a proper way aka uninstaller to "delete" the mentioned folder? I ask because I did not found a dedicated uninstaller for this. Since it is a working computer I can provide infos on Monday. |
The logs will be in your %temp% folder. The files will all start with something similar to Microsoft_.NET_Core_SDK_2.1.400_-preview(x86)_20180629212714.log. You could delete the folder, but internally the OS will still track them as being installed. Hopefully I can provide a better solution once I examine the log files |
Ok i have found the logs.
Here is the first log file:
I think the answer to my "problem" here are these lines:
So the question is. Why the AspNetCoreSharedFramework_x64 has a dependency on the 2.1.300 SDK? This should not be the case i think? Why has the AspNetCoreSharedFramework_x64 no version number? Anyway, hope you can work with that. If you need the other log files, let me know where i can upload them. |
The .NET Core SDKs install SxS. If two bundles (EXE installers) ship the same copy of an MSI, the MSI is reference counted and won't be removed until all the EXEs that reference it are removed. For the uninstall you ran it would simply decrement the reference. The shared framework does have a version, but the bundle log will typically only report the internal package ID when logging things like bundle dependencies. I'll take a look and see whether the two copies are in fact the same version of the framework. I would have expected that the two SDKs shipped different version of it. |
Somewhere something must be wired the wrong way. Because of the folder within |
I set up a repro machine and it appears there is a problem with the ref counting. @VSDekar, to remove this manually you can try the following:
|
@joeloff Thx for the cmd. I am amazed that you take so much effort just because a random guy appeared and said something does not get uninstalled! Good job! I really appreciate that! 🥇 |
You're welcome. |
@joeloff - I've assigned to you so that you can close once the bug is fixed in the private repo. |
The fix was merged into the repo last week for 2.1.3. |
From @JunTaoLuo on June 29, 2018 21:42
From @VSDekar on June 29, 2018 12:2
We had huge problems with dotnet core SDK 2.1.301 so we went back to 2.1.300. But the uninstaller did not delete the ASP.NET Core runtime.
Because the runtime was still there after we uninstalled 2.1.301 we got some very strange problems.
So my expectation is, that everything that an installer installs on the system will be deleted by the uninstaller. I had to delete manually the folder in
C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App
Thx
Copied from original issue: dotnet/core#1740
Copied from original issue: aspnet/SetupSharedFramework#10
The text was updated successfully, but these errors were encountered: