Skip to content

Commit

Permalink
Unskip RunIndividualTestCase(http2_6.9.1_2) (#57849)
Browse files Browse the repository at this point in the history
It's not quarantined, so there's no pass rate, but I can't get it to fail locally - even with a synthetic delay - and the code has been substantially rewritten since the bug was opened.

Fixes #30373
  • Loading branch information
amcasey authored and captainsafia committed Dec 31, 2024
1 parent eb1058b commit fa54fbc
Showing 1 changed file with 0 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ public static TheoryData<H2SpecTestCase> H2SpecTestCases
get
{
var dataset = new TheoryData<H2SpecTestCase>();
var toSkip = new string[] { "http2/6.9.1/2" };

var testCases = H2SpecCommands.EnumerateTestCases();

Expand All @@ -78,18 +77,11 @@ public static TheoryData<H2SpecTestCase> H2SpecTestCases

foreach (var testcase in testCases)
{
string skip = null;
if (toSkip.Contains(testcase.Item1))
{
skip = "https://github.com/dotnet/aspnetcore/issues/30373";
}

dataset.Add(new H2SpecTestCase
{
Id = testcase.Item1,
Description = testcase.Item2,
Https = false,
Skip = skip,
});

// https://github.com/dotnet/aspnetcore/issues/11301 We should use Skip but it's broken at the moment.
Expand All @@ -100,7 +92,6 @@ public static TheoryData<H2SpecTestCase> H2SpecTestCases
Id = testcase.Item1,
Description = testcase.Item2,
Https = true,
Skip = skip,
});
}
}
Expand Down

0 comments on commit fa54fbc

Please sign in to comment.