Skip to content

Commit

Permalink
Revert "Enable xUnit diagnostic messages (#2505)" (#2522)
Browse files Browse the repository at this point in the history
- xUnit diagnostic messages were enabled in #2505 to help identify hung tests
- However, this also enables log messages for non-serializable theory data (aspnet/KestrelHttpServer#2509), which adds noise to logs
- It doesn't seem possible to disable the "non-serializable data" messages but keep the "long-running test" messages
- Converting all tests to serializable theory data is expensive and complicates test code
- The best solution for now is to revert xUnit diagnostic messages to disabled, and re-enable when needed to identify hung tests
  • Loading branch information
mikeharder authored Apr 25, 2018
1 parent cc38a8d commit cc29a50
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion test/xunit.runner.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@
"$schema": "http://json.schemastore.org/xunit.runner.schema",
"appDomain": "denied",
"methodDisplay": "method",
"diagnosticMessages": true,
"longRunningTestSeconds": 60
}

0 comments on commit cc29a50

Please sign in to comment.