Added provisioner for AMZN Linux AMI

[wrotki]

Tested against EC2 (including creating a multi-node swarm) with Amazon Linux AMI 2016.03 (ami-6869aa05)

However need to specify --amazonec2-device-name=xvdb ,
otherwise the EC2 instance won't be able to boot
due to trying an incorrect boot device

Signed-off-by: Mariusz Borsa [email protected]

[nathanleclaire]

I wonder if we could detect the correct root device automatically... we've run into that issue before. It's not really safe to assume /dev/xvda is the boot disk

[leifg]

Can this be merged?

[wrotki]

I'll see if Nathan's suggestion can be implemented

[wrotki]

I've updated the PR with Amazon Linux detection and updating device name and ssh user name if the AMI appears to be it. Tested manually with the latest Amazon Linux AMI ami-b73b63a0

[mgmorcos]

👍

[R-Gerard]

What's the holdup with merging this?

[inhumantsar]

@nathanleclaire are there changes that need to be made to this before it can be merged?

[nathanleclaire]

I am not maintainer anymore, ping @shin-

[briceburg]

Would this allow the generic driver to provision existing Amazon Linux instances? Currently docker-machine is failing to parse CPE_NAME="cpe:/o:amazon:linux:2017.03:ga" when provisioning to an existing instance using generic driver;

docker-machine --debug create ... output

Detecting the provisioner...
(aws-psa-1) Calling .GetSSHHostname
(aws-psa-1) Calling .GetSSHPort
(aws-psa-1) Calling .GetSSHKeyPath
(aws-psa-1) Calling .GetSSHKeyPath
(aws-psa-1) Calling .GetSSHUsername
Using SSH client type: external
...
About to run SSH command:
cat /etc/os-release
SSH cmd err, output: <nil>: NAME="Amazon Linux AMI"
VERSION="2017.03"
ID="amzn"
ID_LIKE="rhel fedora"
VERSION_ID="2017.03"
PRETTY_NAME="Amazon Linux AMI 2017.03"
ANSI_COLOR="0;33"
CPE_NAME="cpe:/o:amazon:linux:2017.03:ga"
HOME_URL="http://aws.amazon.com/amazon-linux-ami/"

Couldn't set key CPE_NAME, no corresponding struct field found
Error creating machine: Error detecting OS: OS type not recognized
notifying bugsnag: [Error creating machine: Error detecting OS: OS type not recognized]

..

[knoxilla]

@shin- Is there anything we can do to get this merged? Thanks!

[inhumantsar]

@wrotki i think this might need a rebase.

@dgageot could you have a look at this? it's been ready to merge for about a year and a half.

[brentstrong]

@wrotki would you consider rebasing this? It would be a big win for those of us heavily using AWS!

[wrotki]

Pushed a rebase

[brentstrong]

Awesome, thanks so much!!

@shin- or @dgageot would you be able to take a look at this? Much appreciated!

[brentstrong]

Checking up on this. Is there anything I can do to help move this along? @shin- @dgageot

[sestary]

Any idea why this hasn't been merged yet? @shin-

[wrotki]

Nope. I guess everybody is busy with Kubernetes now (and why? Go AWS Fargate for all I know, you'll be sleeping sound). Can we just merge it and move on with our lives please? Shouldn't break anyone as this is a rare scenario, and perhaps it can help someone, so it's a win-win. And I don't feel happy about rebasing again.

[christopher-dG]

Does this work for Amazon Linux 2 which uses systemd?

[brentstrong]

It may, but since this project is no longer merging pull requests, it's unlikely to ever be relevant.

See:
#4537

[christopher-dG]

Oh, shoot. That's unfortunate.