Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support EF7 with dotnet7 #299

Merged

Conversation

jsmith-vensure
Copy link
Contributor

Current config requires EF 8 if using dotnet 7. This change will allow either EF7 or EF8 to be used.

@a-gubskiy a-gubskiy merged commit 43fe786 into dncuug:master Oct 12, 2024
1 of 3 checks passed
@a-gubskiy
Copy link
Member

Thank you!

@adschmu
Copy link
Contributor

adschmu commented Oct 12, 2024

Are you aware that .NET 7 has been EOL for half a years already?

@jsmith-vensure
Copy link
Contributor Author

jsmith-vensure commented Oct 12, 2024

You're absolutely right. This PR is incorrect. Re-reviewing, I need EF7 with dotnet8.

Would resubmitting with something similar to this be sufficient? Unsure of your package requirements:

<ItemGroup> <PackageReference Include="Microsoft.EntityFrameworkCore" Version="[7.0.20,8)"/> </ItemGroup>

For consideration: #300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants